Accept/decline T-compiler backports from Zulip #2155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apiraino
changed the title
apiraino
changed the title
apiraino
force-pushed
the
accept-backports-from-zulip
branch
from
a42cf9d to
b265ac9
Compare
apiraino
changed the title
apiraino
commented
Aug 13, 2025
apiraino
force-pushed
the
accept-backports-from-zulip
branch
from
b265ac9 to
80d4110
Compare
|
I guess this patch went under the radar because I didn't request a review r? triagebot |
apiraino
force-pushed
the
accept-backports-from-zulip
branch
4 times, most recently
from
05aa91f to
6d99fff
Compare
apiraino
commented
Sep 19, 2025
apiraino
force-pushed
the
accept-backports-from-zulip
branch
4 times, most recently
from
f32c8db to
f373c3c
Compare
apiraino
force-pushed
the
accept-backports-from-zulip
branch
6 times, most recently
from
52295ac to
93156bd
Compare
|
r? @Kobzol I think it's ready for another round of review (when you have time) |
Kobzol
reviewed
Oct 23, 2025
apiraino
force-pushed
the
accept-backports-from-zulip
branch
from
943b9d1 to
62d8f88
Compare
Kobzol
approved these changes
Oct 28, 2025
apiraino
force-pushed
the
accept-backports-from-zulip
branch
2 times, most recently
from
24e3df8 to
4c3dd4e
Compare
Kobzol
approved these changes
Oct 28, 2025
Do you mean if on Zulip calling |
This patch adds a new Zulip command: `@triagebot backport <channel> <action> <PR>` Example: - `@triagebot backport stable accept 123456` - `@triagebot backport beta decline 654321` This can be used to post on GitHub a comment when T-compiler accepts/decline to backport a patch that fixes a regression. Limitations: - This command is only available in the `rust-lang/rust` repository - There is no check on the PR number (in case of mistypes, the comment will go elsewhere)
apiraino
force-pushed
the
accept-backports-from-zulip
branch
from
4c3dd4e to
9ce791d
Compare
|
No, on GitHub. Right now the backport command sends a GitHub comment from triagebot with |
|
ah ok! Yes it will trigger a reaction applying the labels (for GH after all it's a normal comment from a GH user). Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a new Zulip command:
@triagebot backport <channel> <action> <PR>Example:
@triagebot backport stable accept 123456@triagebot backport beta decline 654321This can be used to post on GitHub a comment like this one when T-compiler accepts/decline to backport a patch that fixes a regression.
Limitations:
rust-lang/rust, I am not aware of other git repos having this workflow. If we want, maybe in the future we can extend to other repos using our custom Zulip linkfiersTested on a custom Zulip instance.
TODO:
backport acceptor evenaccept) to be used from#t-compiler/backports(topics contain all necessary info to build the command parameters)